[Toolbar] Added show and hide animations #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the material design guidelines
…stad of canvas collor
- moves BottomNavigationAction under BottomNavigation.Action - makes styles global, moves them to getTheme.js - adds ability to use action without label - adds missing paddingTop - adds missing comments - fixes lint
Fix bottom navigation component
…g the material design mation guidelines
…y has some small issues.
Fix getting height of bottom navigation
Current coverage is 100% (diff: 100%)@@ master #80 diff @@
===================================
Files 7 7
Lines 300 300
Methods 7 7
Messages 0 0
Branches 5 5
===================================
Hits 300 300
Misses 0 0
Partials 0 0
|
xotahal
reviewed
Jan 23, 2017
| }).start(); | ||
| } | ||
| hide = () => { | ||
| const { moveAnimated, styles } = this.state; |
There was a problem hiding this comment.
The styles here is always undefined, isn't it?
There was a problem hiding this comment.
Oh 😅, yeah that's still from the bottom navigation where you put the styles in the state.
xotahal
approved these changes
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added show and hide animations just like the BottomNavigation component.