-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ActionButton] Add styles for labels. #76
Conversation
@@ -82,6 +82,9 @@ export default function getTheme(theme, ...more) { | |||
borderRadius: (spacing.actionButtonSize - 16) / 2, | |||
backgroundColor: grey500, | |||
}, | |||
speedDialActionLabel: { | |||
color: grey600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NewOldMax :) We should probably use palette.secondaryTextColor
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You right. I will fix at monday.
As I see, test errors don't related to this PR |
True, I fixed them here. Could you please update your fork to include that commit. I don't want to push those error to master again ... |
Current coverage is 100% (diff: 100%)@@ master #76 diff @@
===================================
Files 7 7
Lines 300 300
Methods 7 7
Messages 0 0
Branches 5 5
===================================
Hits 300 300
Misses 0 0
Partials 0 0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @NewOldMax ;)
See #75