avatarIconProps #69
Merged
avatarIconProps #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. If present, they will be use, else fall back to defaults
xotahal
requested changes
Jan 14, 2017
There was a problem hiding this comment.
Hey @frankros91 :) Did you try to run eslint? yarn lint .. it had to throw error because you did not specify propTypes for iconSize and iconColor. Could you fix it please?
|
@xotahal Fixed :) |
Current coverage is 100% (diff: 100%)@@ master #69 diff @@
===================================
Files 7 7
Lines 300 300
Methods 7 7
Messages 0 0
Branches 5 5
===================================
Hits 300 300
Misses 0 0
Partials 0 0
|
xotahal
approved these changes
Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented options to pass iconSize and iconColor as props to Avatar. If they are present, they will be used, else it will fall back to prior logic.