-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tertiaryText Option #67
Conversation
Hey @mbenjamin618 :) And sorry for delay ... I'm still not sure about this feature. Is there posibility how we could approach what you want to approach only with I'm not saying we don't need tertiaryText, but I would just like to know it's necessary. |
@xotahal Thanks for the response! So far, I've been using the tertiaryText feature in my code on all of the cards I've used. Maybe a way to only have a primary and secondary text option is to recognize a character (\n) from the inputted text to start a new line? This solution seems more complicated than having a third line prop (like tertiaryText) though. |
@mbenjamin618 I don't understand, you can just use |
@HofmannZ you can do both of the solutions you mentioned, but that doesn't allow you to choose what starts on each line. With my addition, you are now able to choose what starts on the third line. For example, if you want to show two different dates on the second and third line in the current implementation you'd have to add spaces to the end of the second line to have the second date start on the third line. With mine, you'd set date1 to the second line and date2 to the tertiaryText prop. |
Yeah, it makes sense. I just have to check everything in demo app. Because it probably changes a behaviour of We probably need it .. but we should probably document that :) |
None of the functionality changed with dynamic, I just added the option to add a third line. |
Thanks @mbenjamin618 |
Added the option to start a third line of text in the ListItem instead of having it automatically wrapped.