[RippleFeedback] Use TouchableOpacity for iOS (#41) #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ming436534
added a commit
to ming436534/react-native-material-ui
that referenced
this pull request
Jan 10, 2017
…otahal#64)" This reverts commit c37d6aa.
xotahal
pushed a commit
that referenced
this pull request
Jan 10, 2017
* Remove code specific to Android in Toolbar Search (#54) All platforms (iOS, android and 3rd party windows) implements BackAndroid (iOS mocks it). * [BottomNavigation] Added component (#52) * Add bottom navigation component * Fixed a bug where the list item component uses the wrong then color refrence * Fixed a bug where the list item component uses a static background instad of canvas collor * Added onPress ad required prop type * Fix bottom navigation component - moves BottomNavigationAction under BottomNavigation.Action - makes styles global, moves them to getTheme.js - adds ability to use action without label - adds missing paddingTop - adds missing comments - fixes lint * Update BottomNavigation.md * Update README.md * Delete BottomNavigationAction.md * Bump version * Added show and hide animations to BottomNavigation component following the material design mation guidelines * Edit based on feedback in pull request * Fix eslint errors * Update jest * Add snapshot tests for Subheader * Add circle.yml * Update codecov.yml * Add codecov.io (#57) * Add tests for Container.react.js * Update README.md * [BottomNavigation] Ability to handle custom Icons instead of icon names. (#62) * [BottomNavigation] Ability to handle custom Icons instead of icon names. * Fix PropTypes. * [RippleFeedback] Use TouchableOpacity for iOS (#41) (#64) * Minor bug fix and added nativa animation driver support for android * Fixed lint error. * Added useNAtiveDriver and fixed the heigth issue * Fix getting height of bottom navigation
xotahal
pushed a commit
that referenced
this pull request
Jan 10, 2017
* Remove code specific to Android in Toolbar Search (#54) All platforms (iOS, android and 3rd party windows) implements BackAndroid (iOS mocks it). * [BottomNavigation] Added component (#52) * Add bottom navigation component * Fixed a bug where the list item component uses the wrong then color refrence * Fixed a bug where the list item component uses a static background instad of canvas collor * Added onPress ad required prop type * Fix bottom navigation component - moves BottomNavigationAction under BottomNavigation.Action - makes styles global, moves them to getTheme.js - adds ability to use action without label - adds missing paddingTop - adds missing comments - fixes lint * Update BottomNavigation.md * Update README.md * Delete BottomNavigationAction.md * Bump version * Added show and hide animations to BottomNavigation component following the material design mation guidelines * Edit based on feedback in pull request * Fix eslint errors * Update jest * Add snapshot tests for Subheader * Add circle.yml * Update codecov.yml * Add codecov.io (#57) * Add tests for Container.react.js * Update README.md * [BottomNavigation] Ability to handle custom Icons instead of icon names. (#62) * [BottomNavigation] Ability to handle custom Icons instead of icon names. * Fix PropTypes. * [RippleFeedback] Use TouchableOpacity for iOS (#41) (#64) * Minor bug fix and added nativa animation driver support for android * Fixed lint error. * Added useNAtiveDriver and fixed the heigth issue * Fix getting height of bottom navigation
xotahal
added a commit
that referenced
this pull request
Jan 10, 2017
* Added bottom navigation component with dacumentation, as dricribed in the material design guidelines * Fixed a bug where the list item component uses a static background instad of canvas collor * Added onPress ad required prop type * Fix bottom navigation component - moves BottomNavigationAction under BottomNavigation.Action - makes styles global, moves them to getTheme.js - adds ability to use action without label - adds missing paddingTop - adds missing comments - fixes lint * [BottomNavigation] Add show and hide animations (#55) * Remove code specific to Android in Toolbar Search (#54) All platforms (iOS, android and 3rd party windows) implements BackAndroid (iOS mocks it). * [BottomNavigation] Added component (#52) * Add bottom navigation component * Fixed a bug where the list item component uses the wrong then color refrence * Fixed a bug where the list item component uses a static background instad of canvas collor * Added onPress ad required prop type * Fix bottom navigation component - moves BottomNavigationAction under BottomNavigation.Action - makes styles global, moves them to getTheme.js - adds ability to use action without label - adds missing paddingTop - adds missing comments - fixes lint * Update BottomNavigation.md * Update README.md * Delete BottomNavigationAction.md * Bump version * Added show and hide animations to BottomNavigation component following the material design mation guidelines * Edit based on feedback in pull request * Fix eslint errors * Update jest * Add snapshot tests for Subheader * Add circle.yml * Update codecov.yml * Add codecov.io (#57) * Add tests for Container.react.js * Update README.md * [BottomNavigation] Ability to handle custom Icons instead of icon names. (#62) * [BottomNavigation] Ability to handle custom Icons instead of icon names. * Fix PropTypes. * [RippleFeedback] Use TouchableOpacity for iOS (#41) (#64) * Minor bug fix and added nativa animation driver support for android * Fixed lint error. * Added useNAtiveDriver and fixed the heigth issue * Fix getting height of bottom navigation * Fix eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using TouchableOpacity for RippleFeedback, on iOS, provides good visual feedback for touches.
https://facebook.github.io/react-native/docs/touchableopacity.html