Free jsonBuffer after printing #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
commented
Jun 13, 2018
| @@ -186,6 +190,8 @@ String _haGetConfig() { | |||
| } | |||
| output += "\n"; | |||
|
|
|||
| jsonBuffer.clear(); | |||
There was a problem hiding this comment.
oops. meant this.
This is not technically required bc buffer will be deconstructed each iteration. Just a reminder that it can be removed after serialization in done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving heap problems from #896. Limited testng prefilling eeprom with bunch of "a"*64 strings and accessing /config when websocket is active.
For example, _onGetConfig method when settings size is
3236/4096