.h splitting and reorg #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lobradov
commented
Apr 10, 2018
lobradov
commented
- Isolated dependencies
- Sensors dependencies in individual sensor files.
- enums, macros and prototypes.
Isolated dependencies sensors dependencies enums, macros and prototypes. I2C dependencies moved to actual sensor files. definitelly redefine
mcspr
reviewed
Apr 11, 2018
code/espurna/config/dependencies.h
Outdated
| @@ -0,0 +1,76 @@ | |||
| #ifndef DEPENDENCIES_H | |||
There was a problem hiding this comment.
Just as sensors this should be pragma once.
There was a problem hiding this comment.
good point, changed.
|
It's a good approach, but I'm worried about the dependencies. For instance: modifying ADC_VCC_ENABLED is useless since this setting is used to set de ADC_MODE at the bottom of the sensors.h file... Maybe that call (ADC_MODE) should be in the analog sensor classes, same thing you did for I2C. |
|
I see what you mean. I can do it - give me a minute. |
|
Let's go! |
|
I had to change some stuff (main problem was with DEBUG_MSG definition order but got it working. Also changed the way the ADC_MODE setting is defined. I think it's a good step. Things look more rational now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.