Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: log mode, allow to skip boot messages #2116

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jan 20, 2020

  • Small optimisation for boot speed skipping log completely when booting.
    ENABLED / DISABLED / SKIP_BOOT modes.
    Can be log level / tag / whatever, need more extensive change for that.
    See: https://gitter.im/tinkerman-cat/espurna?at=5e206b6d0dbd9379ed470747
  • Fixup yield in the _debugSend() always triggering when either WS or TELNET logging is enabled.
  • Fixup issues with Debug: store boot log #2109 & Refactor get/set/del/hasSetting #2048 debugSetup only using defaults from definitions as configuration
  • Fix small issue with DEBUG_SUPPORT negative case, preprocessor needs brackets (and would not even issue a warning without them... since ! in the beginning would apply to DEBUG_SERIAL_SUPPORT value)
  • Somewhat reworked telnet / debug files, moved things around that make sense to be externalized. Add telnet.h, reference telnet.h and ws.h from debug module. Move telnet debug writer to telnet module.

@mcspr mcspr merged commit 495fa18 into xoseperez:dev Jan 20, 2020
@mcspr mcspr deleted the debug/log-mode branch January 20, 2020 22:48
@mcspr mcspr added this to the 1.14.2 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant