Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable default parse mode #16

Merged
merged 1 commit into from
Jan 30, 2022
Merged

feat: disable default parse mode #16

merged 1 commit into from
Jan 30, 2022

Conversation

rojvv
Copy link
Collaborator

@rojvv rojvv commented Jan 29, 2022 •
edited
Loading

  • Fixes many possible problems with formatting. If something needed parsing, the parse mode must be set manually for that.

@rojvv rojvv requested a review from ArnabXD January 29, 2022 19:14
@rojvv rojvv mentioned this pull request Jan 29, 2022
Closed
@ArnabXD
Copy link
Member

ArnabXD commented Jan 29, 2022 •
edited
Loading

How does this impact the general sendMessage/edit etc ? Do we need to pass parseMode everytime we send/edit message ?

@rojvv
Copy link
Collaborator Author

rojvv commented Jan 30, 2022 •
edited
Loading

@ArnabXD yes, everytime only if needed.

@rojvv
Copy link
Collaborator Author

rojvv commented Jan 30, 2022

@ArnabXD if you don't like this, we can continue with #15. But this way is better in my opinion, and we can always change it in the future if we thought it's not. None of the ways are breaking anything.

@ArnabXD
Copy link
Member

ArnabXD commented Jan 30, 2022

Nope, I have no issues,

@ArnabXD ArnabXD merged commit 47c93e4 into main Jan 30, 2022
@ArnabXD ArnabXD deleted the parse-mode branch January 30, 2022 08:09
@rojvv rojvv mentioned this pull request Jan 30, 2022
Merged
@rojvv rojvv added the feat label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnabXD ArnabXD ArnabXD approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rojvv @ArnabXD