Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setext headings in blockquotes #465

Closed
hamvocke opened this issue Aug 13, 2020 · 1 comment
Closed

Setext headings in blockquotes #465

hamvocke opened this issue Aug 13, 2020 · 1 comment

Comments

@hamvocke
Copy link
Contributor

hamvocke commented Aug 13, 2020

There seems to be a problem with Setext headings used within blockquotes.

Take this markdown input:

> Hello
> ----
> this is some other text

Running this on babelmark shows that most renderers will generate a blockquote that contains a heading and a paragraph. Markdig, however, creates a blockquote that contains a paragraph, a horizontal rule and another paragraph.

The CommonMark spec is not absolutely explicit about this case but generally states that --- characters should be treated as a Setext heading if they can be interpreted that way.

Is this something that should be fixed in Markdig to be closer to what other Markdown renderers are doing?

@xoofx
Copy link
Owner

xoofx commented Aug 16, 2020

It's definitely a bug, don't have time to look at this, but in case you have, PR welcome.

hamvocke pushed a commit to hamvocke/markdig that referenced this issue Aug 28, 2020
@xoofx xoofx closed this as completed in ccb7e8e Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants