Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviation matching #296

Closed
MihaZupan opened this issue Jan 26, 2019 · 3 comments · Fixed by #305
Closed

Abbreviation matching #296

MihaZupan opened this issue Jan 26, 2019 · 3 comments · Fixed by #305

Comments

@MihaZupan
Copy link
Collaborator

I've been looking at the AbbreviationParser and came accross this discrepancy between different versions.

As a side-note, markdig currently doesn't match at all in cases like this due to how the TextMatchHelper works internally.

I'd be happy to fix this, just wanted to hear your thoughts on the commonmark issue first.

@xoofx
Copy link
Owner

xoofx commented Jan 27, 2019

You can go ahead with what you think is more relevant/safe/consistent. The TextMatchHelper is one of the helper classes that would definitely need to be revisited 👍

@MihaZupan
Copy link
Collaborator Author

I've written a version of TextMatchHelper as a CompactPrefixTree.
Would you prefer I port it to markdig and add it as a helper class or add a NuGet reference (cross targets all platforms Markdig does)?

@xoofx
Copy link
Owner

xoofx commented Feb 6, 2019

Would you prefer I port it to markdig and add it as a helper class or add a NuGet reference (cross targets all platforms Markdig does)?

Yeah, you can port it, I would like to avoid any dependencies.

MihaZupan added a commit to MihaZupan/markdig that referenced this issue Feb 6, 2019
@xoofx xoofx closed this as completed in #305 Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants