Make possible to upload on esp8266 #1462

brusherru · 2018-10-09T13:50:42Z

It completely closes #1206.
Now you can choose board options in the upload dialog and upload even on ESP8266 boards! 🙌

nkrkv · 2018-10-09T13:52:52Z

PR title?

evgenykochetkov · 2018-10-11T09:33:45Z

Select ESP8266 board from upload menu
Set CPU Frequency to 160MHz (instead of default 80MHz)
Upload to ESP everything is fine so far
Now select Arduino Mega
Try to upload:
Error resolving FQBN: getting build properties for board arduino:avr:mega: invalid option 'CpuFrequency'

brusherru · 2018-10-11T10:00:41Z

@evgenykochetkov already fixed at yesterday evening.
You can see it in the latest fixup commit.

nkrkv · 2018-10-11T16:12:29Z

🐛

Steps to reproduce

On a fresh workspace:

Hit Deploy → Upload to Arduino
Select “Amperka WiFi Slot (not installed)”
Confirm and wait for download
Hit Deploy → Upload to Arduino again

Expected behavior

I should be able to select the “Amperka WiFi Slot” board

Actual behavior

“Loading list of supported boards...” forever

Console output

code
:
"ENOENT"
errno
:
-2
message
:
"ENOENT: no such file or directory, open '/home/nailxx/devel/xod-workspace/__packages__/packages/esp8266/hardware/esp8266@2.4.2/2.4.2/boards.txt'"
path
:
"/home/nailxx/devel/xod-workspace/__packages__/packages/esp8266/hardware/esp8266@2.4.2/2.4.2/boards.txt"
stack
:
"Error: ENOENT: no such file or directory, open '/home/nailxx/devel/xod-workspace/__packages__/packages/esp8266/hardware/esp8266@2.4.2/2.4.2/boards.txt'"
syscall
:
"open"

Note the esp8266@2.4.2 part.

Here’s what actually on FS:

~/devel/xod-workspace
$ tree -d -L 4 __packages__/packages/esp8266/hardware
__packages__/packages/esp8266/hardware
└── esp8266
    └── 2.4.2
        ├── bootloaders
        │   └── eboot
        ├── cores
        │   └── esp8266
        ├── libraries
        │   ├── ArduinoOTA
        │   ├── DNSServer
        │   ├── EEPROM
        │   ├── esp8266
        │   ├── ESP8266AVRISP
        │   ├── ESP8266HTTPClient
        │   ├── ESP8266httpUpdate
        │   ├── ESP8266HTTPUpdateServer
        │   ├── ESP8266LLMNR
        │   ├── ESP8266mDNS
        │   ├── ESP8266NetBIOS
        │   ├── ESP8266SSDP
        │   ├── ESP8266WebServer
        │   ├── ESP8266WiFi
        │   ├── ESP8266WiFiMesh
        │   ├── Ethernet
        │   ├── GDBStub
        │   ├── Hash
        │   ├── SD
        │   ├── Servo
        │   ├── SoftwareSerial
        │   ├── SPI
        │   ├── SPISlave
        │   ├── TFT_Touch_Shield_V2
        │   ├── Ticker
        │   └── Wire
        ├── tests
        │   ├── device
        │   └── host
        ├── tools
        │   └── sdk
        └── variants
            ├── adafruit
            ├── arduino_spi
            ├── arduino_uart
            ├── d1
            ├── d1_mini
            ├── ESPDuino
            ├── espino
            ├── espinotee
            ├── espresso_lite_v1
            ├── espresso_lite_v2
            ├── generic
            ├── modwifi
            ├── nodemcu
            ├── oak
            ├── phoenix_v1
            ├── phoenix_v2
            ├── thing
            ├── wifiduino
            ├── wifinfo
            ├── wifio
            ├── wifi_slot
            ├── wiolink
            └── xinabox

62 directories

nkrkv · 2018-10-11T16:32:08Z

Error
`/usr/bin/arduino-cli --config-file=/tmp/arduino-cliz3iTY1/.cli-config.yml upload --fqbn esp8266:esp8266:wifi_slot --port /dev/ttyUSB0 -t /tmp/xod_temp_sketchbook9WAhh5/xod_1539275390503_sketch` failed with code 1
The error has no formatter, which is a bug. Report the issue to XOD developers.

Formatting uploader failures as-is is OK. That should not be a bug

nkrkv · 2018-10-12T11:49:07Z

packages/xod-client-electron/src/arduinoDependencies/messages.js

@@ -31,6 +35,7 @@ export default {
    note: [librariesInstalled(libraryNames), packagesInstalled(packageNames)]
      .filter(a => !!a)
      .join('\r\n'),
+    solution: 'Now you are able to upload the code',


Now you are able to upload the program

nkrkv · 2018-10-12T11:50:30Z

packages/xod-client-electron/src/shared/messages.js

@@ -28,6 +28,9 @@ export const DEBUG_SESSION_STOPPED_ON_TAB_CLOSE = {
 };
 export const DEBUG_LOST_CONNECTION = 'Lost connection with the device.';

+export const UPLOAD_PROCESS_BEGINS =
+  'Begin uploading compiled code onto the board...';


Uploading compiled code to the board...

packages/xod-client-electron/src/upload/components/PopupUploadConfig.jsx

nkrkv · 2018-10-12T11:53:50Z

packages/xod-client-electron/src/upload/messages.js

@@ -4,4 +4,8 @@ export default {
    note: `Cloud compilation does not support ${boardName} yet.`,
    solution: 'Try to compile it on your own computer',
  }),
+  UPLOAD_TOOL_ERROR: ({ message }) => ({
+    title: 'Error ocured in the Upload process',


Upload tool exited with error

packages/xod-client-electron/src/upload/messages.js

nkrkv · 2018-10-12T12:03:10Z

packages/xod-client-electron/src/upload/reducer.js

+      return switchUploadBlock(action, state);
+
+    case UPLOAD:
+      return switchUploadBlock(action, state);


A potential race condition is here. Suggest tracking independently: instead of single blocked use isInstallingArduinoDependencies and isUploading.

…y `cpu` option

brusherru · 2018-10-12T14:12:54Z

@nkrkv can I squash fixup commits?

nkrkv · 2018-10-12T14:56:15Z

Of course

nkrkv

LGTM

… for esp

…rocess just begins

…tion of arduino dependencies

…lation is in the progress

…-cli

…l package (temporary kludge)

brusherru added the t:feat label Oct 9, 2018

brusherru self-assigned this Oct 9, 2018

brusherru requested a review from a team October 9, 2018 13:50

brusherru changed the title ~~Feat 1206 upload on esp~~ Make possible to upload on esp8266 Oct 9, 2018

brusherru force-pushed the feat-1206-upload-on-esp branch from d5152a3 to 2df72aa Compare October 9, 2018 15:56

brusherru force-pushed the feat-1206-extensible-board-packages branch from 21056fa to 9593b0f Compare October 9, 2018 16:30

brusherru force-pushed the feat-1206-upload-on-esp branch from 2df72aa to f3a5cc5 Compare October 9, 2018 17:09

brusherru force-pushed the feat-1206-extensible-board-packages branch from 9593b0f to 4aa7e7e Compare October 10, 2018 09:21

brusherru force-pushed the feat-1206-upload-on-esp branch from f3a5cc5 to 65582d2 Compare October 10, 2018 09:23

brusherru force-pushed the feat-1206-extensible-board-packages branch from 4aa7e7e to f2ecaaa Compare October 10, 2018 10:12

brusherru changed the base branch from feat-1206-extensible-board-packages to master October 10, 2018 17:40

brusherru force-pushed the feat-1206-upload-on-esp branch from 65582d2 to 3d6f9c7 Compare October 10, 2018 17:40

brusherru force-pushed the feat-1206-upload-on-esp branch from 3d6f9c7 to 32dd458 Compare October 11, 2018 16:11

nkrkv requested changes Oct 12, 2018

View reviewed changes

refactor(arduino-cli): parse all board options instead of parsing onl…

1c7f78d

…y `cpu` option

brusherru force-pushed the feat-1206-upload-on-esp branch from 0ba859a to 43fbb0f Compare October 12, 2018 14:14

nkrkv approved these changes Oct 12, 2018

View reviewed changes

brusherru added 6 commits October 12, 2018 18:09

feat(xod-client-electron): make possible upload on boards with options

0416e0a

fix(xod-client-electron): temporary fix to make possible compile code…

280e0f8

… for esp

fix(xod-client-electron): do not show 100% progress bar when upload p…

d63675f

…rocess just begins

fix(xod-client-electron): stop debug session on new upload

15249de

feat(arduino-cli): update arduino-cli to version 0.3.1

ae4ac15

chore(xod-client-electron): change messages about successful installa…

de6254a

…tion of arduino dependencies

brusherru added 4 commits October 12, 2018 18:10

tweak(xod-client-electron): block upload button when uploading/instal…

f69d6a1

…lation is in the progress

tweak(xod-client-electron): format error messages produced by arduino…

fd743ee

…-cli

chore(xod-client-electron): do not show warnings about ws package

bf9eeba

tweak(arduino-cli): remove staging directory before download/instal…

96a0f97

…l package (temporary kludge)

brusherru force-pushed the feat-1206-upload-on-esp branch from 43fbb0f to 96a0f97 Compare October 12, 2018 15:13

brusherru merged commit 69495b3 into master Oct 12, 2018

brusherru deleted the feat-1206-upload-on-esp branch October 12, 2018 17:39

nkrkv mentioned this pull request Oct 16, 2018

Update changelog for upcoming 0.25.0 #1471

Merged

per1234 mentioned this pull request Jan 3, 2019

Breaking change made without major version bump esp8266/Arduino#5572

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make possible to upload on esp8266 #1462

Make possible to upload on esp8266 #1462

brusherru commented Oct 9, 2018

nkrkv commented Oct 9, 2018

evgenykochetkov commented Oct 11, 2018

brusherru commented Oct 11, 2018 •

edited

Loading

nkrkv commented Oct 11, 2018

nkrkv commented Oct 11, 2018

nkrkv Oct 12, 2018

nkrkv Oct 12, 2018

nkrkv Oct 12, 2018

nkrkv Oct 12, 2018

brusherru commented Oct 12, 2018 •

edited

Loading

nkrkv commented Oct 12, 2018

nkrkv left a comment

Make possible to upload on esp8266 #1462

Make possible to upload on esp8266 #1462

Conversation

brusherru commented Oct 9, 2018

nkrkv commented Oct 9, 2018

evgenykochetkov commented Oct 11, 2018

brusherru commented Oct 11, 2018 • edited Loading

nkrkv commented Oct 11, 2018

Steps to reproduce

Expected behavior

Actual behavior

Console output

nkrkv commented Oct 11, 2018

nkrkv Oct 12, 2018

Choose a reason for hiding this comment

nkrkv Oct 12, 2018

Choose a reason for hiding this comment

nkrkv Oct 12, 2018

Choose a reason for hiding this comment

nkrkv Oct 12, 2018

Choose a reason for hiding this comment

brusherru commented Oct 12, 2018 • edited Loading

nkrkv commented Oct 12, 2018

nkrkv left a comment

Choose a reason for hiding this comment

brusherru commented Oct 11, 2018 •

edited

Loading

brusherru commented Oct 12, 2018 •

edited

Loading