Use new frames proxy #198
Merged
Use new frames proxy #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90f22ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
neekolas
commented
Feb 21, 2024
| @@ -1,3 +1,3 @@ | |||
| export const OPEN_FRAMES_PROXY_URL = "https://open-frames-proxy.fly.dev/"; | |||
| export const OPEN_FRAMES_PROXY_URL = "https://frames.xmtp.chat/"; | |||
There was a problem hiding this comment.
I'm now hosting this on Cloudflare Workers, which should be faster since they are closer to the end user.
rygine
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now have an Open Frames proxy client that duplicates some of the code in here, but with broader argument types. I am wrapping that proxy client but with narrower types specific to XMTP.
The new client also adds the
frameInfofield which includes fully parsed Frame data, so we are adding that to the return types.