Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode groups and conversations sequentially to fix iOS pool errors #462

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Aug 5, 2024

image

 LOG  Alix loaded 50 groups in 55ms
 LOG  Alix synced 50 groups in 6ms
 LOG  Bo synced 50 groups in 89ms
 LOG  Bo loaded 50 groups in 54ms

@cameronvoell cameronvoell requested a review from a team as a code owner August 5, 2024 18:06

return results

var results: [String] = []
Copy link
Contributor Author

@cameronvoell cameronvoell Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and removed TaskGroup from listAll and listConversations since it could lead to similar issues with too many db connections, and I did not observe any slowdown in the test for loading 2000 conversations.

before the change I saw "LOG Loaded 1995 conversations in 5717ms" and after I saw actually slightly faster "LOG Loaded 1995 conversations in 5595ms"

@@ -107,7 +106,6 @@ export enum TestCategory {
all = 'all',
tests = 'tests',
group = 'group',
createdAt = 'createdAt',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected to be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, these tests were initially just documenting different behaviors between iOS and Android, but looking at them now, they just pass / fail randomly based off random order that groups are returned. tldr, dont think these tests are useful at the moment, and are just creating extra noise, in my opinion, as the person who wrote them :-P

@cameronvoell cameronvoell merged commit 37478c8 into main Aug 5, 2024
4 of 5 checks passed
@cameronvoell cameronvoell deleted the cv/fix-ios-pool-error branch August 5, 2024 19:25
Copy link

github-actions bot commented Aug 5, 2024

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants