Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cocoapod dependencies #425

Merged
merged 18 commits into from
Nov 20, 2024
Merged

Conversation

nplasterer
Copy link
Contributor

With the deprecation of macOS-12 we need to remove our dependencies on several cooapods.

@nplasterer nplasterer force-pushed the np/remove-cocoapod-dependencies branch from d6ee8b5 to 2581d56 Compare November 14, 2024 21:49
@nplasterer nplasterer force-pushed the np/remove-cocoapod-dependencies branch from 670ab53 to 0b86bf8 Compare November 15, 2024 00:51
@nplasterer
Copy link
Contributor Author

We should also try to fix the docs in this PR.

@nplasterer nplasterer marked this pull request as ready for review November 19, 2024 19:56
@nplasterer nplasterer requested a review from a team as a code owner November 19, 2024 19:56
@nplasterer
Copy link
Contributor Author

Tests pass and example app builds.
I had to remove wallet connect because it depended on an old version of cocoapods.

To get it working on your machine I would follow these steps

  • Clean Build Folder
  • Reset Package Caches
  • Resolve Package Versions
  • Build

@cameronvoell
Copy link
Contributor

cameronvoell commented Nov 20, 2024

Tests pass and example app builds. I had to remove wallet connect because it depended on an old version of cocoapods.

To get it working on your machine I would follow these steps

  • Clean Build Folder
  • Reset Package Caches
  • Resolve Package Versions
  • Build

I had to go to build settings "Frameworks, LIbraries, and Embedded Content" and manually select secp256k1 and click the - button to remove it. There is a diff in git so I'll go ahead and commit.

Example app and tests running for me now

image

@nplasterer nplasterer merged commit 5ce4f85 into main Nov 20, 2024
2 checks passed
@nplasterer nplasterer deleted the np/remove-cocoapod-dependencies branch November 20, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants