Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction 📟
ApiClientError has in the past been an enum. However, throwing the enum in an error catching context did not afford the ability to update the localized description.
Purpose ℹ️
Refactor ApiClientError from an Enum to a Struct which conforms to LocalizedError and GenericErrorDescribing. Conforming to LocalizedError enables the ability to updated the localizedDescription and pass along
libXMTP
API generated errors to SDK clients.Scope 🔭
ApiClient
ApiClientError
GenericErrorDescribing
Out of Scope ⚔️
development
orproduction
environment; neither of which would be suitable for automated testing.