Bump to latest rust for streaming improvements #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Feb 29, 2024
| @@ -44,5 +44,5 @@ Pod::Spec.new do |spec| | |||
| spec.dependency "web3.swift" | |||
| spec.dependency "GzipSwift" | |||
| spec.dependency "Connect-Swift", "= 0.3.0" | |||
| spec.dependency 'LibXMTP', '= 0.4.2-beta3' | |||
| spec.dependency 'LibXMTP', '= 0.4.2-beta5' | |||
There was a problem hiding this comment.
FYI @zombieobject we really shouldn't have the cocoapod and the SPM pointing to different versions of libxmtp.
There was a problem hiding this comment.
Noted. I will be sure to bump both at the same time going forward.
cameronvoell
approved these changes
Feb 29, 2024
|
Looks like these test failures might be legit. Streaming conversations seems to not be working as expected. |
zombieobject
added
on-hold
zombieobject
force-pushed
the
np/bump-latest-rust
branch
from
229c1ae to
c9c14a2
Compare
zombieobject
approved these changes
Mar 1, 2024
This was referenced Mar 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps to the latest rust versions to get the latest streaming improvements.