Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process streamed group message #593

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Process streamed group message #593

merged 9 commits into from
Mar 28, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Mar 26, 2024 •
edited
Loading

Part of #527

Exposes a new method on groups called process_streamed_group_message which takes in a byte array of mlsv1.GroupMessage and then returns a GroupMessage then the bindings call into() to convert it to a FfiMessage

Exposes a new method called process_streamed_welcome_message which takes in a byte array of mlsv1.WelcomeMessage and then returns a WelcomeMessage then the bindings call into() to convert it to a FfiGroup

@nplasterer nplasterer self-assigned this Mar 26, 2024
@nplasterer nplasterer changed the title first pass at the new group message decoder Process streamed group message Mar 26, 2024
@nplasterer nplasterer marked this pull request as ready for review March 27, 2024 21:42
@nplasterer nplasterer requested a review from a team March 27, 2024 21:42
neekolas
neekolas approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this looks good, aside from the two lint warnings.

richardhuaaa
richardhuaaa approved these changes Mar 27, 2024
View reviewed changes
xmtp_mls/src/groups/subscriptions.rs Outdated Show resolved Hide resolved
@nplasterer nplasterer merged commit 124c53f into main Mar 28, 2024
7 checks passed
@nplasterer nplasterer deleted the np/expose-process-stream-messages branch March 28, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardhuaaa richardhuaaa richardhuaaa approved these changes

@neekolas neekolas neekolas approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nplasterer @neekolas @richardhuaaa