Update to nan 2.x for nodejs 4.x #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomhughes @astro thanks! So this is based on nan2-astro brach which is based on nan2 branch which is based on #73 Nice collaborative effort :) @astro can you review/merge this? |
|
Tracking: nodejs/node#2798 |
|
Works great for me. My attempt also tried to use libicu in a different way... which doesn't seem necessary. It might be worth a second look if these interfaces break some day. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on https://github.com/node-xmpp/node-stringprep/tree/nan2-astro but omits things that were changing the way the calls to icu work, some of which were breaking tests.
It also fixes one issue in
preparewhere the result string was being freed before it was returned which was causing theleakcheck.jstest to fail.