-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package name #541
Update package name #541
Conversation
This throw errors in newer versions of NPM(not having a name)
Thanks, comma missing, can you tell me for what operation(s) npm is failling? |
Comma is fixed, I actually couldn't install the package via npm due to this. Npm is node package manager? |
Maybe this is what you're looking for https://github.com/xmppjs/xmpp.js/tree/master/packages/xmpp.js |
Installing the deps of xmpp.js works fine, installing xmpp.js via npm works at the tag. The current master branch doesn't install via npm
My branch
It still throws errors about package version etc this doesn't solve all of these problems. |
the root of the xmpp.js repository isn't a "valid" npm/node module so even with the name field you wouldn't be able to use it (see lerna) And npm/yarn don't allow to use subdirectories in git urls. npm/npm#2974 If you want to use the repository, the only way is
and then const client = require('./xmpp.js/packages/client') |
@sonnyp could you please add this info on how to install the lib somewhere in the main README file |
Just to note here, for future searchers, This doc http://xmppjs.org/client/ is not up to date The following code
will not work properly, the What we need to do is the following:
and we will get a proper set up client got this info from src code https://github.com/xmppjs/xmpp.js/blob/master/packages/client/index.js#L29 |
This throw errors in newer versions of NPM(not having a name)