Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AN000129 on linux #241

Merged
merged 15 commits into from
Jul 16, 2021

Conversation

DaveAtkinsonXMOS
Copy link
Contributor

@DaveAtkinsonXMOS DaveAtkinsonXMOS commented Jul 15, 2021

Application note AN00129 HID Class was not working on linux, because the format of the HID Report Descriptor pursueded the kernel that the attached device was a joystick, despite declaring that it was a mouse. HID Report Descriptor replaced with one shamelessly copied from the USB Device Class Definition for Human Interface Devices (HID) Version 1.11. This describes a 3 button mouse and pointer. Also some general tidying up.
Merging this pull request will close #60

Copy link
Contributor

@xross xross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the one conflict to resolve.

@DaveAtkinsonXMOS DaveAtkinsonXMOS marked this pull request as ready for review July 15, 2021 09:59
Copy link
Contributor

@xross xross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hid_defs.h needs a licence comment

For some reason the app note build now fails?

It could be a source code include that now xdoc cannot find due to source changes?

@DaveAtkinsonXMOS DaveAtkinsonXMOS requested a review from xross July 15, 2021 14:24
@DaveAtkinsonXMOS
Copy link
Contributor Author

Ross, I believe I've addressed your issues... lmk

Copy link
Contributor

@xross xross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

@DaveAtkinsonXMOS DaveAtkinsonXMOS merged commit 3d0bfb3 into xmos:develop Jul 16, 2021
@DaveAtkinsonXMOS DaveAtkinsonXMOS deleted the fix/AN000129_on_linux branch July 27, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AN000129 HID Mouse example doesn't operate correctly on Linux hosts
2 participants