-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AN000129 on linux #241
Fix AN000129 on linux #241
Conversation
…s xcore{ai,200} arches.
* Use symbolic constants. * Reduce scope of unsafe code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just the one conflict to resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hid_defs.h needs a licence comment
For some reason the app note build now fails?
It could be a source code include that now xdoc cannot find due to source changes?
Ross, I believe I've addressed your issues... lmk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks.
Application note AN00129 HID Class was not working on linux, because the format of the HID Report Descriptor pursueded the kernel that the attached device was a joystick, despite declaring that it was a mouse. HID Report Descriptor replaced with one shamelessly copied from the USB Device Class Definition for Human Interface Devices (HID) Version 1.11. This describes a 3 button mouse and pointer. Also some general tidying up.
Merging this pull request will close #60