Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.26.0.0 #84

Merged
merged 65 commits into from
Jul 8, 2022
Merged

Release v1.26.0.0 #84

merged 65 commits into from
Jul 8, 2022

Conversation

xluciano
Copy link

@xluciano xluciano commented Jul 6, 2022 •
edited
Loading 

* update SDK to version v1.26.0
* refactor CLI arguments in setup scripts in order to support Amazon KWD
* port XMOS KWD adapters to latest version of the SDK
* delay startup of AVS console till .asoundrc file is found
* clone portaudio from github instead of using wget as it is more reliable

xluciano added 30 commits June 29, 2022 08:51
@xluciano
Merge branch 'master' of https://github.com/alexa/avs-device-sdk into…
c6201aa 
… feature/merge_1.26.0

# Conflicts:
#	KWD/CMakeLists.txt
#	KWD/KWDProvider/src/CMakeLists.txt
#	KWD/KWDProvider/src/KeywordDetectorProvider.cpp
#	SampleApp/src/CMakeLists.txt
#	SampleApp/src/SampleApplication.cpp
#	SampleApp/src/main.cpp
#	shared/KWD/acsdkKWDImplementations/XMOS/CMakeLists.txt
#	shared/KWD/acsdkKWDImplementations/XMOS/GPIO/CMakeLists.txt
#	shared/KWD/acsdkKWDImplementations/XMOS/GPIO/include/GPIO/GPIOKeywordDetector.h
#	shared/KWD/acsdkKWDImplementations/XMOS/GPIO/src/CMakeLists.txt
#	shared/KWD/acsdkKWDImplementations/XMOS/GPIO/src/GPIOKeywordDetector.cpp
#	shared/KWD/acsdkKWDImplementations/XMOS/HID/CMakeLists.txt
#	shared/KWD/acsdkKWDImplementations/XMOS/HID/include/HID/HIDKeywordDetector.h
#	shared/KWD/acsdkKWDImplementations/XMOS/HID/src/CMakeLists.txt
#	shared/KWD/acsdkKWDImplementations/XMOS/HID/src/HIDKeywordDetector.cpp
#	shared/KWD/acsdkKWDImplementations/XMOS/include/XMOS/XMOSKeywordDetector.h
#	shared/KWD/acsdkKWDImplementations/XMOS/src/CMakeLists.txt
#	shared/KWD/acsdkKWDImplementations/XMOS/src/XMOSKeywordDetector.cpp
#	tools/Install/pi.sh
#	tools/Install/setup.sh
@xluciano
Restore old files
bdf466f
@xluciano
Move old files to the new locations
caffa25
@xluciano
Remove unnecessary files
667ba47
@xluciano
Update XMOS adapter classes to comply with v1.26.0
e5c63e4
@xluciano
Remove old files
d6dd2b0
@xluciano
Update setup scripts
7cbd594
@xluciano
Add CHANGELOG version
97ff875
@xluciano
Add missing files
b66db60
@xluciano
Set op point to config file
035cab7
@xluciano
Protect changes with define
adcc0c6
@xluciano
Move common operations to base class
e39ba8d
@xluciano
Move checks to base class function
508e0b4
@xluciano
Remove old code
76c8163
@xluciano
Enable flag for Sensory
c4acfcc
@xluciano
Merge pull request #78 from xmos/feature/v1.26.0
66c69bf 
Update SDK to version v1.26.0
@xluciano
Enable flag for Sensory
9f9cab7
@xluciano
Add test changes
8981465
@xluciano
Add flag
abdb774
@xluciano
Fix errors
1e5e589
@xluciano
Re-introduced deleted lines
bb533b1
@xluciano
Re-introduced deleted lines
cb1398c
@xluciano
Update comments
a35545e
@xluciano
Delay start of AVS till asoundrc is copied
7c56113
@xluciano
Add comments
ebda508
@xluciano
Update info
de41c70
@xluciano
Undo test change
0121ed7
@xluciano
Fix printouts
d7d0f3d
@xluciano
Merge pull request #81 from xmos/feature/delay_start
32c3db7 
Delay start of AVS till asoundrc is copied
@xluciano
Add option to build Sensory KWD
b07d132
xluciano added 23 commits July 4, 2022 18:24
@xluciano
Remove test code
470217e
@xluciano
Initialize member variable
c3c57c9
@xluciano
Do not pass keyword detector type to pi.sh via CLI argument, as pi.sh…
30c7cb3 
… is called from within setup.sh.
@xluciano
Add info
4d89665
@xluciano
Set member variable as static and add set function
50c490e
@xluciano
Merge pull request #79 from xmos/feature/sensory
e9bc421 
Update Sensory adapter to be configured with operating point 12
@xluciano
Merge from xmos_v1.26.0.0
7f8a35c
@xluciano
Fix merge errors
8141c41
@xluciano
Use github repo to download portaudion
1cc82e2
@xluciano
Fix command
86280e9
@xluciano
Fix command
a295fb5
@xluciano
Update git clone command
a76742c
@xluciano
Update git clone command
9584c76
@xluciano
Add info
4c436ed
@xluciano
Protect code
3b0c298
@xluciano
Fix use of static variable
1204628
@xluciano
Fix use of static variable
6cc0ce2
@xluciano
Fix compiler flags
951b340
@xluciano
Initialize static variable
51f5926
@xluciano
Fix initialization of variable
5d5016d
@xluciano
Add comments
460cc12
@xluciano
Fix indentation
c0d2ed7
@xluciano
Merge pull request #83 from xmos/feature/amz_updates
ccd8e71 
Refactor CLI arguments of scripts and other changes
@xluciano xluciano added the size:S Small issue or pull request label Jul 6, 2022
@xluciano xluciano self-assigned this Jul 6, 2022
@xluciano xluciano added this to the v1.26.0.0 milestone Jul 6, 2022
@xluciano xluciano requested a review from mbanth July 7, 2022 08:43
mbanth
mbanth approved these changes Jul 7, 2022
View reviewed changes
Copy link

@mbanth mbanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved without conducting a detailed review. The number of files changed makes a detailed review very expensive. The fact that the vast majority of them have been made by Amazon also means that I do not have the necessary information to evaluate them. Previously merged pull requests for changes made by XMOS, including #78, #79, #81 and #83, have been reviewed in detail.

@xluciano xluciano merged commit ffbbc5d into master Jul 8, 2022
@xluciano xluciano mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbanth mbanth mbanth approved these changes

Assignees

@xluciano xluciano

Labels
size:S Small issue or pull request
Projects
None yet
Milestone
v1.26.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xluciano @mbanth