Fixes/workarounds for Steam client menus/flickering #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2024
geekosaur
approved these changes
Apr 27, 2024
More specifically, ignore ClientMessageEvents for unmanaged windows. Steam likes to send _NET_ACTIVE_WINDOW requests for all its windows, including override-redirect ones, which used to result in an invocation of `windows` with a no-op Endo—equivalent to a call to `refresh`. But this refresh makes Steam close its menus immediately. Fixes: ValveSoftware/steam-for-linux#9376 Fixes: xmonad/xmonad#451
Implements a replacement event handler for 'ConfigureRequestEvent' to work around misbehaving client applications such as Steam, URxvt and others that try to restore their absolute window positions. Primarily motivated by the Steam client being almost completely unusable in xmonad lately. (I've been running this code in my xmonad.hs for other purposes for years.)
For ease of use, provide `fixSteamFlicker` as a pre-packaged `floatConfReqHook` that can easily be added directly to a `handleEventHook`. Also, for discoverability, re-export it from X.U.Hacks.
|
Confirmed to work by a couple users, merging then. |
|
I will test it when it gets into gentoo portage. Hopefully 0.18.1? |
Suppose this is an important enough fix to make a release. I was going to look at #825 soon so let's do that and then a release. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A fix, a tool for workarounds, and a workaround:
X.H.EwmhDesktops: Fix menus in Steam client
More specifically, ignore
ClientMessageEvents for unmanaged windows. Steam likes to send_NET_ACTIVE_WINDOWrequests for all its windows, including override-redirect ones, which used to result in an invocation ofwindowswith a no-op Endo—equivalent to a call torefresh. But this refresh makes Steam close its menus immediately.Fixes: ValveSoftware/steam-for-linux#9376
Fixes: xmonad/xmonad#451
X.H.FloatConfigureReq: New module to customize ConfigureRequest handling
Implements a replacement event handler for
ConfigureRequestEventto work around misbehaving client applications such as Steam, rxvt-unicode and others that try to restore their absolute window positions. Primarily motivated by the Steam client being almost completely unusable in xmonad lately.(I've been running this code in my xmonad.hs for other purposes for years.)
X.H.FloatConfigureReq: Add fixSteamFlicker
For ease of use, provide
fixSteamFlickeras a pre-packagedfloatConfReqHookthat can easily be added directly to ahandleEventHook.Also, for discoverability, re-export it from X.U.Hacks.
Checklist
I've read CONTRIBUTING.md
I've considered how to best test these changes (property, unit, manually, ...) and concluded:
been running the
X.H.FloatConfigureReqstuff for years locally; the rest is fresh and ideally needs to be manually tested by some folksI updated the
CHANGES.mdfile