Documentation tweaks for X.H.StatusBar(.PP)
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slotThe
reviewed
May 4, 2021
TheMC47
force-pushed
the
add-loggers-reference
branch
from
cb19549 to
91e7751
Compare
slotThe
reviewed
May 10, 2021
TheMC47
force-pushed
the
add-loggers-reference
branch
from
91e7751 to
26af2ba
Compare
TheMC47
force-pushed
the
add-loggers-reference
branch
from
26af2ba to
644f993
Compare
liskin
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The example in
X.H.StatusBar.PPwasn't updated when we removed theXfromstatusBarProp, and #535 shows that the loggers weren't really discoverable.@slotThe do you think this is better?
Checklist
- [ ] I tested my changes with xmonad-testing- [ ] I updated theCHANGES.mdfile- [ ] I updated theXMonad.Doc.Extendingfile (if appropriate)