Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wrp go from v2 to v3 #166

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Aug 23, 2022

What's included:

  • Upgrade wrp go from v2 to v3
  • general dependency updates

Why upgrade wrp go from v2 to v3?
For some reason wrp-go/v2 expects codec to contain GenHelperDecoder but that's not the case

Running tool: /Users/odc/.go/bin/go test -timeout 30s -run ^(TestDetermineTokenAcquirer|TestMetrics|TestHandleWebhook)$ github.com/xmidt-org/svalinn

# github.com/xmidt-org/wrp-go/v2
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:48:20: undefined: codec.GenHelperEncoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:435:20: undefined: codec.GenHelperDecoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:460:20: undefined: codec.GenHelperDecoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:552:20: undefined: codec.GenHelperDecoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:821:20: undefined: codec.GenHelperEncoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:1136:20: undefined: codec.GenHelperDecoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:1161:20: undefined: codec.GenHelperDecoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:1245:20: undefined: codec.GenHelperDecoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:1466:20: undefined: codec.GenHelperEncoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:1656:20: undefined: codec.GenHelperDecoder
/Users/odc/go/pkg/mod/github.com/xmidt-org/wrp-go/v2@v2.0.1/messages_codec.go:1656:20: too many errors
FAIL    github.com/xmidt-org/svalinn [build failed]

@denopink denopink self-assigned this Aug 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #166 (29dfe01) into main (7d75abf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   51.14%   51.14%           
=======================================
  Files           8        8           
  Lines         567      567           
=======================================
  Hits          290      290           
  Misses        269      269           
  Partials        8        8           
Flag Coverage Δ
unittests 51.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
primaryHandler.go 79.31% <ø> (ø)
requestParser/createRecord.go 91.00% <ø> (ø)
requestParser/requestParser.go 71.24% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@denopink denopink added the bug Something isn't working label Aug 23, 2022
@denopink denopink merged commit 7f1ae00 into main Aug 23, 2022
@denopink denopink deleted the denopink/dependency/upgrade-wrp-go-from_v2_to_v3 branch August 23, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant