Fix compilation of the project when using Xcode 9 new build system and CocoaPods #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d CocoaPods With current podspec, one .xib file is getting picked up as a source, and is getting into Xcode Compile Sources build step in CocoaPods generated project. New build system is more strict than the old one, and prohibits this by saying: ``` error: unexpected duplicate task: CompileXIB /Path-To-Project/Pods/XLPagerTabStrip/Sources/ButtonCell.xib (in target 'XLPagerTabStrip') ``` This behavior is described in [this CocoaPods issue](CocoaPods/CocoaPods#7079). This PR changes source_files search path from being * to more specific code-related one *.{h,m,swift}, thus picking only sources into sources. This fix can be verified by installing XLPagerTabStrip, trying to build with new Build System - it will fail. Then you can remove ButtonCell.xib file from Pods -> XLPagerTabStrip -> Compile Sources build phase and this time project will build successfully.
mtnbarreto
approved these changes
Apr 10, 2018
|
👍 |
|
@mtnbarreto This change may need a push. The podspec file in cocoapods not change yet. https://github.com/CocoaPods/Specs/blob/master/Specs/4/f/b/XLPagerTabStrip/8.0.1/XLPagerTabStrip.podspec.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current podspec, one .xib file is getting picked up as a source, and is getting into Xcode Compile Sources build step in CocoaPods generated project.
New build system is more strict than the old one, and prohibits this by saying:
This behavior is described in this CocoaPods issue.
This PR changes source_files search path from being * to more specific code-related one *.{h,m,swift}, thus picking only sources into sources.
This fix can be verified by installing XLPagerTabStrip, trying to build with new Build System - it will fail. Then you can remove ButtonCell.xib file from Pods -> XLPagerTabStrip -> Compile Sources build phase and this time project will build successfully.