feat(rules/iverilog): Improve the iverilog build rules #5677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
24bit-xjkp
commented
Sep 29, 2024
24bit-xjkp
commented
- Add System Verilog support
- Support add_defines by add_options
- Use vcd format instead of lxt2 to support WaveTrace plugin
1. Add System Verilog support 2. Support add_defines by add_options 3. Use vcd format instead of lxt2 to support WaveTrace plugin
waruqi
reviewed
Sep 30, 2024
| for _, option_name in ipairs(target:get("options") or {}) do | ||
| local option = project.option(option_name) | ||
| add_defines(option:enabled() and option:get("defines")) | ||
| end |
There was a problem hiding this comment.
不要这么搞，参考
xmake/xmake/rules/qt/moc/xmake.lua
Line 71 in 0f7e1ea
waruqi
reviewed
Sep 30, 2024
xmake/rules/iverilog/xmake.lua
Outdated
| @@ -20,7 +20,8 @@ | |||
|
|
|||
| -- @see https://github.com/xmake-io/xmake/issues/3257 | |||
| rule("iverilog.binary") | |||
| set_extensions(".v", ".vhd") | |||
| -- support SystemVerilog | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.