Improve cmake.install for ninja #5365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -979,6 +979,14 @@ end | |||
| -- do build for ninja | |||
| function _build_for_ninja(package, configs, opt) | |||
There was a problem hiding this comment.
_install_for_ninja 也要加，或者在 package/tools/ninja.lua 里抽象出一个函数给 install/build 都加上
There was a problem hiding this comment.
这是cmake的bug，不应该在 tools.ninja里面处理
|
我在 tools.cmake 里面，抽象到一个单独 func 了。 |
In tools.cmake, I abstracted it to a separate func. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5353