Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation #5335

Merged
merged 55 commits into from
Jul 23, 2024
Merged

Improve installation #5335

merged 55 commits into from
Jul 23, 2024

Conversation

waruqi
Copy link
Member

@waruqi waruqi commented Jul 11, 2024

#5325
#5308

Roadmap

  • Improve xpack/xmake pack
  • Improve xmake install
    • Add set_prefixdir("/", {bindir, libdir, includedir}) to improve installation prefix directory in target
    • Fix install with admin
    • Dump so/dll dependents and filter installed so/dll files in package
      • Add utils.binary.deplibs module to dump dependent shared libraries
    • Support add_installfiles("", {public = true})
    • Support add_headerfiles("", {public = true})
    • Fix install rpath issue
      • Add add_rpathdirs("xxx", {installonly = true}) to set install rpath.
      • Add set_policy("build.rpath", false) to disable build rpath for target
      • Add set_policy("install.rpath", false) to disable install rpath for target
      • Add utils.binary.rpath module
    • Improve c++ module installation
  • Add install tests

@waruqi waruqi added this to the v2.9.4 milestone Jul 11, 2024
@waruqi waruqi marked this pull request as ready for review July 15, 2024 03:35
@waruqi waruqi closed this Jul 17, 2024
@waruqi waruqi reopened this Jul 17, 2024
@waruqi waruqi merged commit d4364ef into dev Jul 23, 2024
38 checks passed
@waruqi waruqi deleted the install branch July 23, 2024 04:50
@ChrisCatCP
Copy link
Contributor

@waruqi
Copy link
Member Author

waruqi commented Jul 26, 2024

https://github.com/NixOS/patchelf

我知道有这个,但是这个发行版一般不预装, xmake install 这种基础组件还要用第三方依赖,毕竟不可靠。。macos 下那个是 基本就自带了,所以问题不大。

cmake 下走的自己 native 实现,自己解析的。。后面有空也得这么搞。。不过短时间可以用第三方的应付下

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


https://github.com/NixOS/patchelf

I know this exists, but this distribution is generally not pre-installed. Basic components like xmake install also require third-party dependencies, which are unreliable after all. . The one under macos basically comes with it, so it’s not a big problem.

The native implementation is implemented under cmake and parsed by itself. . I have to do this later when I have time. . But in the short term, you can use a third party to deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants