-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Vala support #5302
Improve Vala support #5302
Conversation
When compiling multiple files valac fails to find symbols (i.e SomeClass from a.vala using in b.vala), changed build to process all source files at once
Did you test other examples. e.g. https://github.com/xmake-io/xmake/tree/dev/tests/projects/vala/staticlib it does not work. and others. https://github.com/xmake-io/xmake/tree/dev/tests/projects/vala |
Checking rn |
Strange, vala/lua test doesn't compile even with upstream rule file... |
Implemented requested changes, all tests passing except for lua, but lua fails because of xmake (and maybe arch linux, it has headers who knows where) coz gcc fails to find lua includes from Also fixed |
Couldn't get valac build to run only when needed, but everything else should be correct now |
But incremental compilation still doesn't work. bash-5.2$ xmake
[ 20%]: compiling.vala src/mymath.vala
[ 70%]: compiling.vala src/main.vala
[100%]: build ok, spent 0.588s
bash-5.2$ xmake
[ 20%]: compiling.vala src/mymath.vala
[ 70%]: compiling.vala src/main.vala
[100%]: build ok, spent 0.571s |
Oh, I think I'm starting to understand how batchcmds work, not completely though... |
|
Again, shows how, but now why. Maybe worth adding some explaining comments to it? Anyway, thanks for taking time to review and merge my PR |
When compiling multiple files valac fails to find symbols (i.e SomeClass from a.vala using in b.vala), changed build to process all source files at once