fix CMake package defaultflags and runtimes support #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthapz
force-pushed
the
fix-cmake-packages
branch
2 times, most recently
from
9857c48
to
417886b
Compare
Arthapz
force-pushed
the
fix-cmake-packages
branch
2 times, most recently
from
4979b01
to
c35e789
Compare
Arthapz
force-pushed
the
fix-cmake-packages
branch
from
c35e789
to
40a5806
Compare
waruqi
reviewed
Apr 27, 2024
waruqi
reviewed
Apr 27, 2024
waruqi
reviewed
Apr 27, 2024
waruqi
reviewed
Apr 27, 2024
waruqi
reviewed
Apr 27, 2024
waruqi
reviewed
Apr 27, 2024
Arthapz
force-pushed
the
fix-cmake-packages
branch
from
0e9dcaa
to
eb95459
Compare
Arthapz
force-pushed
the
fix-cmake-packages
branch
from
eb95459
to
0713cf3
Compare
SirLynix
added a commit
to NazaraEngine/ShaderLang
that referenced
this pull request
Apr 29, 2024
Fixes a bug in XMake 2.9.1 see xmake-io/xmake#5025
|
It cannot get correct default flags for windows arm (cross). |
waruqi
reviewed
Aug 30, 2024
| local runtimes = package:runtimes() | ||
| if runtimes then | ||
| local fake_target = {is_shared = function(_) return false end, | ||
| sourcekinds = function(_) return "c" end} |
There was a problem hiding this comment.
why not use package? it will break if package toolchain is changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my last PR #4927 broke some cmake libraries from xrepo on windows (CMAKE_CXX_FLAGS override default flags)
so here a new version which use CMAKE_CXX_FLAGS_RELEASE and autodetect default flags