Add cppfront's header(*.h2) support #4943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Apr 7, 2024
xmake/rules/cppfront/xmake.lua
Outdated
| @@ -35,31 +35,58 @@ rule("cppfront.build") | |||
| end | |||
| end | |||
| end) | |||
| on_buildcmd_file(function (target, batchcmds, sourcefile_cpp2, opt) | |||
| on_buildcmd_files(function (target, batchcmds, sourcebatch, opt) | |||
There was a problem hiding this comment.
不要一起处理，on_buildcmd_file 拆成单文件粒度，是可以并行编译，这么搞，只能串行编译了，会很慢。
There was a problem hiding this comment.
主要是如果cpp2先处理，如果依赖的h2后处理，生成的cpp编译的时候可能提示缺少头文件。
There was a problem hiding this comment.
补充提交了，使用add_deps方式的
There was a problem hiding this comment.
那应该拆成两个 rule ，一个处理 cpp2 一个处理 h2 ，然后通过 add_deps("", {order = true}) 配置依赖关系，确保执行顺序
waruqi
reviewed
Apr 7, 2024
xmake/rules/cppfront/xmake.lua
Outdated
| cpp2_files = {} | ||
| all_files = {} | ||
| for _, sourcefile in ipairs(sourcebatch.sourcefiles) do | ||
| if string.endswith(sourcefile, ".h2") then |
This reverts commit 99e57fc.
waruqi
reviewed
Apr 7, 2024
xmake/rules/cppfront/xmake.lua
Outdated
| batchcmds:set_depmtime(os.mtime(sourcefile_h)) | ||
| batchcmds:set_depcache(target:dependfile(sourcefile_h)) | ||
| end) | ||
|
|
||
| -- define rule: cppfront.build | ||
| rule("cppfront.build") |
There was a problem hiding this comment.
那这里也得改成 cppfront.build.cpp2 ，跟 .h2 保持命名风格一致
|
另外，测下增量编译是否 work |
Also, test whether incremental compilation works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加cppfront对于.h2的支持 #4938