-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support of internal partitions #3133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthapz
force-pushed
the
msvc-internal-partition
branch
6 times, most recently
from
December 4, 2022 19:50
a753121
to
0494bd3
Compare
Arthapz
force-pushed
the
msvc-internal-partition
branch
from
December 4, 2022 20:39
0494bd3
to
6320572
Compare
Arthapz
changed the title
add support of msvc specific /internalPartition for modules
add support of internal partitions
Dec 4, 2022
Arthapz
force-pushed
the
msvc-internal-partition
branch
from
December 4, 2022 21:49
fff4982
to
54d1c3b
Compare
the
is for fallback generator, compiler implementing p1689r5 should handle it (msvc does) |
Is there a better way to detect it automatically? For example by analysing the module source code. |
it's possible i think, but i think it will complexifies a the code, i'll see if i can do something simple |
waruqi
reviewed
Dec 5, 2022
Arthapz
force-pushed
the
msvc-internal-partition
branch
from
December 5, 2022 14:46
a2b4f7b
to
718cccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.