Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of internal partitions #3133

Merged
merged 6 commits into from
Dec 5, 2022

Conversation

Arthapz
Copy link
Member

@Arthapz Arthapz commented Dec 4, 2022

No description provided.

@Arthapz Arthapz force-pushed the msvc-internal-partition branch 6 times, most recently from a753121 to 0494bd3 Compare December 4, 2022 19:50
@Arthapz Arthapz changed the title add support of msvc specific /internalPartition for modules add support of internal partitions Dec 4, 2022
@Arthapz
Copy link
Member Author

Arthapz commented Dec 4, 2022

the

{values = {["internalpartition"] = true}}

is for fallback generator, compiler implementing p1689r5 should handle it (msvc does)

@waruqi
Copy link
Member

waruqi commented Dec 5, 2022

the

{values = {["internalpartition"] = true}}

is for fallback generator, compiler implementing p1689r5 should handle it (msvc does)

Is there a better way to detect it automatically? For example by analysing the module source code.

@Arthapz
Copy link
Member Author

Arthapz commented Dec 5, 2022

it's possible i think, but i think it will complexifies a the code, i'll see if i can do something simple

@waruqi waruqi merged commit 00b740c into xmake-io:dev Dec 5, 2022
@Arthapz Arthapz deleted the msvc-internal-partition branch February 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants