Compile private C++20 modules #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please remove empty dummy.cpp, it's unused. |
waruqi
reviewed
Dec 1, 2022
waruqi
reviewed
Dec 1, 2022
Arthapz
force-pushed
the
compile-private-modules
branch
from
ccd67b6
to
cb12af8
Compare
waruqi
reviewed
Dec 1, 2022
waruqi
reviewed
Dec 1, 2022
Arthapz
force-pushed
the
compile-private-modules
branch
from
de7d073
to
0760075
Compare
|
We also need to consider incremental compilation. It does not work for this test case. But other tests work. for clang ruki-2:private_module ruki$ xmake
[ 0%]: generating.cxx.module.deps src/use.mpp
[ 0%]: generating.cxx.module.deps src/dep1.mpp
[ 0%]: generating.cxx.module.deps src/dep2.mpp
[ 14%]: generating.cxx.module.bmi dep1
[ 28%]: generating.cxx.module.bmi dep2
[ 42%]: build.cxx.module src/use.mpp
[ 71%]: archiving.release libprivate_module.a
[100%]: build ok!
ruki-2:private_module ruki$ xmake
[ 0%]: generating.cxx.module.deps src/use.mpp
[ 42%]: build.cxx.module src/use.mpp
[ 71%]: archiving.release libprivate_module.a
[100%]: build ok! |
now it should work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to build privates modules