[Galaxy] Optimize Python / XOS #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a pretty significant speedup for python bindings. It could still be much faster, but due to pyo3 and rust being overbearing with their memory and lifetimes B.S, we're kinda unable to get full zero-copies.
At least, I haven't found a great way to get full zero-copy support. So python has to return the frame from the tick function and it gets copied into what's supposed to be the zero-copy buffer.
But we're getting much closer. Python still remains only supported for local native windows, but I hope next we'll be able to support wasm <> python interactions, and even better yet react-native.
That will allow us to write some really badass python demo codes. Especially if we never need to write any weird API code (fuck http, flask, and anything fetch-related).
python-galaxy.mov