Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new lints from Rust nightly #3006

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

shssoichiro
Copy link
Collaborator

@shssoichiro shssoichiro commented Aug 30, 2022

Fixes instances of lints for:

  • unstable_name_collisions (due to addition of unstable ilog method)
  • clippy::partialeq_to_none
  • clippy::needless_borrow

@codecov-commenter
Copy link

Codecov Report

Base: 86.38% // Head: 86.42% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (0183ec4) compared to base (75fcd60).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3006      +/-   ##
==========================================
+ Coverage   86.38%   86.42%   +0.04%     
==========================================
  Files          89       89              
  Lines       34071    34069       -2     
==========================================
+ Hits        29432    29445      +13     
+ Misses       4639     4624      -15     
Impacted Files Coverage Δ
src/activity.rs 98.95% <100.00%> (ø)
src/deblock.rs 94.90% <100.00%> (-0.01%) ⬇️
src/ec.rs 83.51% <100.00%> (ø)
src/encoder.rs 87.16% <100.00%> (+0.03%) ⬆️
src/me.rs 95.59% <100.00%> (ø)
src/rdo.rs 85.76% <100.00%> (+0.46%) ⬆️
src/transform/inverse.rs 99.67% <100.00%> (ø)
src/transform/mod.rs 89.70% <100.00%> (ø)
src/context/frame_header.rs 66.06% <0.00%> (-2.27%) ⬇️
src/context/partition_unit.rs 88.33% <0.00%> (-0.28%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shssoichiro shssoichiro changed the title Fix new clippy lints from Rust nightly Fix new lints from Rust nightly Aug 30, 2022
@shssoichiro shssoichiro merged commit 59b21f9 into xiph:master Aug 30, 2022
@shssoichiro shssoichiro deleted the 20220830-nightly-clippy-fix branch August 30, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants