Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gitignore files in hops templates #275

Closed
1 task done
ZauberNerd opened this issue Nov 22, 2017 · 0 comments
Closed
1 task done

Rename gitignore files in hops templates #275

ZauberNerd opened this issue Nov 22, 2017 · 0 comments
Assignees

Comments

@ZauberNerd
Copy link
Contributor

ZauberNerd commented Nov 22, 2017

This is my intent (choose one)

  • I want to provide or change a feature

The problem

hops init creates templates without a .gitignore file, which means that users who use it, need to create the .gitignore files themselves.

This is caused by npm, because a .gitignore files is never published (npm/npm#1862)

Proposed solution

We could rename the .gitignore file in the current hops-* templates to _gitignore and rename them again after unzipping the package.

ZauberNerd added a commit that referenced this issue Nov 22, 2017
Because npm never publishes a `.gitignore` file, we need to rename
our `.gitignore` files in our templates to `_gitignore` and have the
`hops-local-cli` `init()` method rename it again, after unpacking.

Read more about it: npm/npm#1862

Related to: #275
@ZauberNerd ZauberNerd mentioned this issue Nov 22, 2017
2 tasks
@ZauberNerd ZauberNerd self-assigned this Nov 22, 2017
dmbch pushed a commit that referenced this issue Nov 22, 2017
Because npm never publishes a `.gitignore` file, we need to rename
our `.gitignore` files in our templates to `_gitignore` and have the
`hops-local-cli` `init()` method rename it again, after unpacking.

Read more about it: npm/npm#1862

Related to: #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant