Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init icon size is not normal due to missing null check #1792

Merged

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying merged commit 97bf804 into xiaoyifang:staged Sep 30, 2024
7 checks passed
Copy link

sonarcloud bot commented Sep 30, 2024

@shenlebantongying shenlebantongying deleted the fix/null-tbicon branch September 30, 2024 23:07
@KonstantinDjairo
Copy link
Contributor

KonstantinDjairo commented Oct 1, 2024

related to the config code, i think there's a issue in the windows platform
image
it doesn't respect whether the checkbox is marked or not, causing it to get in front of other windows.
could you please handle that checkbox a bit more gently ? i dont know what we can do in c++ to ensure that the value is going to be respected or whether we can confirm if it's saved in the config file.

interestingly this error has only occurred in windows, in every other OS it's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants