clean: port away from QTextCodec
in slob.cc
and clean up iconv
#1734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to remove usage of
Core5Compat
.Is this change correct?
The Qt5 version of
QTextCodec::codecForName
underneath uses ICUGNU libiconv has a large table of encoding alias
https://git.savannah.gnu.org/gitweb/?p=libiconv.git;a=blob;f=lib/encodings.def;h=e5063d329886818033e6d3aa14618c75d8b07852;hb=HEAD#l441
ICU also has a big table of encoding alias
https://github.com/unicode-org/icu/blob/1414e80f6c1376afa65eb388aaaafb53169fc3dc/icu4c/source/data/mappings/convrtrs.txt#L891
Both includes names from various sources like INNA, glibc, java, windows, so I assume
QTextCodec::codecForName
andiconv_open
are equal.unrelated
QStringConverter
since Qt6.5 also uses ICU to support equal set of encodings like old QTextCodec btw.Maybe the correct path forward is just use ICU instead, because multiple dependencies of GD already depends on it one way or another.