fix: prioritize the manual set full text index option per dictionary #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyifang
force-pushed
the
fix/fulltext-metadata
branch
from
23f4bac
to
67081f0
Compare
src/dict/dictionary.hh
Outdated
Comment on lines
318
to
319
| //default to true; | ||
| bool enable_FTS = true; | ||
| std::optional< bool > enable_FTS; |
There was a problem hiding this comment.
Comment is wrong now. It should be changed to "The enable_fts option in metadata.toml"
I think enable_FTS should be renamed to metadata_enable_FTS.
As of now, the 3 variables
- can_FTS
- fts.enabled
- enable_FTS
have no obvious difference.
There was a problem hiding this comment.
To properly initialize std::optional< bool > metadata_enable_FTS = std::nullopt
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.