feat: utilize CMake for macOS .app
and .dmg
creation
#1492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encompasses various improvements:
.dmg
or.app
locally possible (by removing the need to run macdeployqt, otool, codesign after build)And less important ones,
qmake
.plist
fileKnown issue:
The Homebrew Qt and macdeployqt's rpath bug is still not fixed, so we still have to use Qt's installer.
Known alternatives:
CMake's CPack's Drag&Drop generator is 💩💩💩. Lacks basic features and obscure to use.
So we still uses
brew install create-dmg
to create dmg installer.