Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: utilize CMake for macOS .app and .dmg creation #1492

Conversation

shenlebantongying
Copy link
Collaborator

@shenlebantongying shenlebantongying commented May 4, 2024

This PR encompasses various improvements:

And less important ones,

  • One more step closer to removing qmake
  • Remove outdated keys from .plist file
  • Reduce .dmg size for by switching compression method. (macOS 10.15+)
  • ...

Known issue:

The Homebrew Qt and macdeployqt's rpath bug is still not fixed, so we still have to use Qt's installer.

Known alternatives:

CMake's CPack's Drag&Drop generator is 💩💩💩. Lacks basic features and obscure to use.

So we still uses brew install create-dmg to create dmg installer.

@shenlebantongying
Copy link
Collaborator Author

shenlebantongying commented May 4, 2024

Can any one of the known Mac users try this build? @sonerfromnurland @yshumy @homocomputeris @initial-ddl

My Mac doesn't have enough space to set up an VM to test if it works on someone else's machine.

https://github.com/shenlebantongying/goldendict-ng/releases/tag/test_mac_2

In theory, it should work, but I am not sure.

@shenlebantongying
Copy link
Collaborator Author

I think my next PR would be replacing macOS's qmake builds in CI, then we can make a pre-release to check out problems and checkout the requirements for homebrew submission.

Then we submit to homebrew cask after the next formal release. @xiaoyifang

Copy link

sonarcloud bot commented May 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@homocomputeris
Copy link

Can any one of the known Mac users try this build?

I have an Intel-based one.

@shenlebantongying shenlebantongying merged commit a7eaef5 into xiaoyifang:staged May 5, 2024
13 checks passed
@shenlebantongying shenlebantongying deleted the feat/mac_cmake_bundler branch May 5, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants