CMake: let cpack generate package. #1463
Conversation
atauzki
force-pushed
the
staged
branch
5 times, most recently
from
9f5d075
to
abf20bf
Compare
CMakeLists.txt
Outdated
| @@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.25) # ubuntu 23.04 Fedora 36 | |||
|
|
|||
| # Qt6.4+ only | |||
|
|
|||
| option(WITH_FFMPEG_PLAYER "Enable support for FFMPEG player" ON) | |||
| option(WITH_FFMPEG_PLAYER "Enable support for FFMPEG player" OFF) | |||
There was a problem hiding this comment.
Maybe don't change this default yet. What if someone uses older Qt. Also, Qt multimedia has multiple backends now, FFmpeg isn't guaranteed to be the default on some Linux distros.
There was a problem hiding this comment.
Just do that with -DWITH_FFMPEG_PLAYER=ON. I don't think it's matter, but most versions in our workflow don't need it.
There was a problem hiding this comment.
There are a few places in the wild that aren't in our control. I think we can wait some time and delete all FFmpeg code. We don't need to turn it off now.
- https://src.fedoraproject.org/rpms/goldendict-ng/blob/rawhide/f/goldendict-ng.spec#_80
- https://codeberg.org/hashirama/ajattix/src/commit/6108b9c4839a5760ae5bfb76451c945257b7419f/ajatt/packages/dictionaries.scm#L53-L54
- https://github.com/archlinuxcn/repo/blob/770b047a3591e6e24f0962e784bbbaae6acceb10/archlinuxcn/goldendict-ng-git/PKGBUILD#L53-L57 (this is in my control, but i don't want to change it 😅 )
There was a problem hiding this comment.
Maybe we should add deprecated warning until we can safely remove it when qt6.4+ are widely used.
There was a problem hiding this comment.
I don't know the release plan, maybe we can cut a release for the last version that supports Qt5 first 😅 @xiaoyifang
revert ffmpeg player changes.
shenlebantongying
force-pushed
the
staged
branch
from
b5814b5
to
7a8f4b6
Compare
|
Execute the
cpackdirectly in builddir orcmake --build build --target packageand generate both the 7z and nsis installer.Or use
cpack -G <generator>to generate other format of packages.