clean: deprecations that won't break Qt5 compatibility #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setAudioPlaybackProgram( *externalPlayer ); | ||
| playerPtr.reset( externalPlayer.take() ); |
There was a problem hiding this comment.
They realize that .take() makes the existence of this pointer type pointless, so it is removed.
| @@ -41,7 +41,7 @@ Sources::Sources( QWidget * parent, Config::Class const & cfg ): | |||
| // anyone? | |||
| QItemEditorCreatorBase * programTypeEditorCreator = new QStandardItemEditorCreator< ProgramTypeEditor >(); | |||
|
|
|||
| itemEditorFactory->registerEditor( QVariant::Int, programTypeEditorCreator ); | |||
There was a problem hiding this comment.
| @@ -72,14 +72,14 @@ void ExternalAudioPlayer::onViewerDestroyed( QObject * destroyedViewer ) | |||
| emit error( errorMessage ); | |||
| } | |||
| } | |||
| else if ( viewer.data() == destroyedViewer ) | |||
| viewer.take(); // viewer finished and died -> release ownership. | |||
There was a problem hiding this comment.
take() by nothing is reset to null.
shenlebantongying
force-pushed
the
clean/dep-qt5
branch
from
70699a5
to
d85940b
Compare
shenlebantongying
force-pushed
the
clean/dep-qt5
branch
from
c45e9eb
to
48fc8fc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.