fix: CMake problems found by the openBSD package #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
changed the title
* remove unused WITH_XAPIAN option * don't link Qt TTS if not requested
shenlebantongying
force-pushed
the
fix/fix-cmake-problems
branch
from
8e2ddea
to
c55aad4
Compare
shenlebantongying
force-pushed
the
fix/fix-cmake-problems
branch
from
9c0cc85
to
007c92a
Compare
* remove unused WITH_XAPIAN option * don't link Qt TTS if not requested * Disable some code when TTS is not requested
shenlebantongying
force-pushed
the
fix/fix-cmake-problems
branch
from
6d21245
to
900cc02
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disable some code that does useless things when Qt TTS is not enabled.
See the comments here: https://github.com/openbsd/ports/blob/971a335e5114e2b952d8f491af87b97c897914d7/textproc/goldendict-ng/Makefile#L55-L63 by @klemensn (sorry for unnecessary troubles.)