Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in libao code, dlopen is used to load some plugins #46

Closed
ngn999 opened this issue Apr 14, 2022 · 7 comments · Fixed by #48
Closed

in libao code, dlopen is used to load some plugins #46

ngn999 opened this issue Apr 14, 2022 · 7 comments · Fixed by #48
Labels
bug Something isn't working

Comments

@ngn999
Copy link
Collaborator

ngn999 commented Apr 14, 2022

but the path is hardcode here: https://github.com/xiph/libao/blob/master/src/audio_out.c#L298
and macdeployqt can't handle dependencies like this.

the original maclibs/libao.dylib looks like has some hack:

image

I'm looking for a solution.

EDIT:
the patch version is here:

https://github.com/timonwong/libao/commits/goldendict

https://github.com/goldendict/goldendict/blob/b2e673961d28ca5eb920a909091252d3321f09d6/maclibs/scripts/libao.txt

@ngn999 ngn999 changed the title in libao code, dlopen is used to load some plugin in libao code, dlopen is used to load some plugins Apr 14, 2022
@ngn999
Copy link
Collaborator Author

ngn999 commented Apr 14, 2022

I think this is a more stable solution: xiph/libao#10

@xiaoyifang
Copy link
Owner

xiaoyifang commented Apr 14, 2022

could the plugins be disabled?
is the plugin neccessary for the play sound method.
https://github.com/xiph/libao/blob/20dc8ed9fa4605f5c25e7496ede42e8ba6468225/src/audio_out.c#L288

@ngn999
Copy link
Collaborator Author

ngn999 commented Apr 14, 2022

should the plugins be disabled?

is the plugin neccessary for the play sound method.

https://github.com/xiph/libao/blob/20dc8ed9fa4605f5c25e7496ede42e8ba6468225/src/audio_out.c#L288

goldendict must enable the plugin to play audiao.

@ngn999
Copy link
Collaborator Author

ngn999 commented Apr 14, 2022

someone has build alsa as build-in: https://github.com/Tslabdev/tslab_libao_library/commits/master
I can build macos.so as build-in.

@xiaoyifang
Copy link
Owner

xiaoyifang commented Apr 14, 2022

maybe in the future ,we can change libao to other packages such as portaudio etc?

@ngn999
Copy link
Collaborator Author

ngn999 commented Apr 14, 2022

QWebEngine contains a chromium, but it can't play audio without libao+ffmpeg?

@xiaoyifang
Copy link
Owner

xiaoyifang commented Apr 14, 2022

as far as I know ,the builtin chromium can not play speex format.

if libao+ffmpeg does not work ,try to chagne the audio play engine to qtmultimedia and have a try.

there is a period of time ,I have used chromium engine to play sound .
096f21f

maybe we can add built-in chromium engine as a third option for user to choose.
image

@xiaoyifang xiaoyifang added the bug Something isn't working label Apr 15, 2022
xiaoyifang pushed a commit that referenced this issue Apr 15, 2022
libao.dylib is universal library now
xiaoyifang added a commit that referenced this issue Apr 15, 2022
libao: static link libmacosx.so plugin, fix #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants