Skip to content

Commit

Permalink
feat: allow changing icon on macOS by stop overriding icon set by Inf…
Browse files Browse the repository at this point in the history
…o.plist
  • Loading branch information
shenlebantongying committed Sep 6, 2024
1 parent c599bbf commit 92ef64d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,10 @@ int main( int argc, char ** argv )

QHotkeyApplication::setApplicationName( "GoldenDict-ng" );
QHotkeyApplication::setOrganizationDomain( "https://github.com/xiaoyifang/goldendict-ng" );
#ifndef Q_OS_MACOS
// macOS icon is defined in Info.plist
QHotkeyApplication::setWindowIcon( QIcon( ":/icons/programicon.png" ) );
#endif

#ifdef Q_OS_WIN
// TODO: Force fusion because Qt6.7's "ModernStyle"'s dark theme have problems, need to test / reconsider in future
Expand Down

0 comments on commit 92ef64d

Please sign in to comment.