update react-swipeable to v5 #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far! |
|
Is this going to be merged? |
|
@gcosgreave-us I got pulled away due to some bug fixes for react-swipeable, but I do have a tentative plan to get back to this early next week. It is close. |
|
Awesome news @hartzis 👍 |
hartzis
changed the title
|
@xiaolin I think this is ready for you to take a look.
|
|
@hartzis Sounds good, i'll take a look. |
hartzis
commented
May 16, 2019
|
|
||
| let offsetPercentage = (delta / galleryWidth * 100); | ||
| let offsetPercentage = (absX / galleryWidth * 100); |
There was a problem hiding this comment.
delta here in react-swipeable v4 was actually absX so updated to use absX in v5.
|
Just as a heads up, I was able to run the example and test everything I could and from my end. Let me know if you have questions/concerns/feedback. |
xiaolin
approved these changes
May 24, 2019
|
LGTM, I'm going to do a round of testing on my end and merge. |
|
@hartzis Looked through and everything seems to be working correctly. Thanks for the amazing PR! |
xiaolin
pushed a commit
that referenced
this pull request
Jul 21, 2023
* update react-swipeable to v5, match functionality * Bump react-swipeable * use dir from swipeable * clean up spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update react-swipable to v5
TODOs:
dirand try to clean up directional logic?...
I found some time, 🎉 and I know we discussed possibly just removing
react-swipeablein #321, but opened this to see what updating to v5 would look like.