Persistable + ViewManager #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…autonomously read + write state.
* Updates to persistable column widths + Report on-demand and sizing-mode autosize events as if they were manually sized - we want to persist these widths as if the user had made them individually themselves. Only in managed mode are we truly deferring to autosize. + Clarify that `mode` can not be passed as an option to `autosizeAsync() - we always read and respect the gridModel's mode. + Additional typing / comment tweaks * Updates to PersistenceProvider + Catch unknown type / unparseable config in factory and return null - see TB Admin Grid Test - it has an option to pass a bogus key. + Minor comment formatting / put ctor in protected block --------- Co-authored-by: Greg Solomon <greg@xh.io>
# Conflicts: # CHANGELOG.md
+ Remove property on superclass that was storing reference to provider - as of now we don't think we will generally be saving or using those references + Remove try/catch - create() catches internally
+ Add/export `JsonBlob` interface + Type service APIs
* Updates to persistable column widths + Report on-demand and sizing-mode autosize events as if they were manually sized - we want to persist these widths as if the user had made them individually themselves. Only in managed mode are we truly deferring to autosize. + Clarify that `mode` can not be passed as an option to `autosizeAsync() - we always read and respect the gridModel's mode. + Additional typing / comment tweaks * Updates to PersistenceProvider + Catch unknown type / unparseable config in factory and return null - see TB Admin Grid Test - it has an option to pass a bogus key. + Minor comment formatting / put ctor in protected block * Fix DashContainerModel PersistenceProvider construction * Remove DashCanvasModel.publishState * Fix DashViewProvider.clearRaw impl and add Persistence Provider logging * Rename PersistablePanelState -> PanelPersistState --------- Co-authored-by: Anselm McClain <atm@xh.io>
This was referenced Oct 31, 2024
Closed
|
Current WIP state implements the approach sketched out in my comments from last night on #3814. Note also new Toolbox branch with PR @ xh/toolbox#737 - revised Portfolio app example to help us exercise the new persistence code. |
…alone util functions
+ Update `listAsync()` to inline `loadSpec` with all other args in a single object. + Expand `JsonBlob` interface to include additional properties present on all blobs. + Only POST back params to `updateAsync` that have actually been spec'd for update.
+ Respect `showSaveButton` prop, specifically allow showing button when not dirty if prop set to `always`. + Avoid weird/empty menu dividers if private/shared views show in submenu. Ensure separators render in general as expected. + Add doc comments to `View` interface.
+ Additional minor tweaks and cleanups
+ Update `FilterChooserFilterLike` for accuracy - remove base `Filter` from union type. + Additional usages of `Thunkable`
+ Add trailing `s` for consistency for actual model property and default persisted sub-path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.