Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Timing block to app loading track message #3796

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

lbwexler
Copy link
Member

Add new Timing block to app loading track message.

  • New state for 'Authenticating'
  • Misc cleanups

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

+ New state for 'Authenticating'
+ Misc cleanups
@lbwexler lbwexler requested a review from amcclain September 28, 2024 21:15
Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice, thank you!

Would it be worth splitting up INITIALIZING to distinguish between HOIST_INITIALIZING and APP_INITIALIZING - transitioning to the latter right before we call await this.appModel.initAsync();?

Wasn't sure how much logic might be out there (if any) that keys off of that state.

@amcclain amcclain changed the title Add new Timing block to app loading track message. Add new Timing block to app loading track message Oct 3, 2024
Copy link
Member Author

@lbwexler lbwexler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!!

@lbwexler
Copy link
Member Author

lbwexler commented Oct 3, 2024

Went for the suggested additional states. Think we should go ahead and leverage all this, and I doubt anyone was observing it specifically.

@lbwexler lbwexler merged commit 9a94f56 into develop Oct 3, 2024
2 checks passed
@lbwexler lbwexler deleted the timings branch October 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants