Improve handling of instance changes #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Associated with HC PR: xh/hoist-core#387 |
|
Note: should test in stage to ensure properly handles changing instances (unable to test locally) |
lbwexler
reviewed
Aug 29, 2024
| }, | ||
| { | ||
| track: () => XH.environmentService.serverInstance, | ||
| run: () => this.gridModel.agApi.refreshCells({columns: ['name'], force: true}) |
There was a problem hiding this comment.
no need to be stingy about the columns that get refreshed here!
There was a problem hiding this comment.
Just refreshAsync()? Seems like a very good time to ensure your entire picture of what's in the cluster is up to date.
lbwexler
reviewed
Aug 29, 2024
svc/EnvironmentService.ts
Outdated
| private checkServerVersionAsync = async () => { | ||
| const data = await XH.fetchJson({url: 'xh/version'}), | ||
| {instanceName, appVersion, appBuild, mode} = data; | ||
| private checkServerStatusAsync = async () => { |
There was a problem hiding this comment.
again -- only concern here is with the new name -- what if we called it serverInfo
+ Tailor /xh/environment return based on auth user - support minimal unauthorized payload for backwards compat with existing usages, but mix-in full details for authenticated users. + Client now calls this endpoint both for initial load and for ongoing polling. + Rework `xhAppStatusCheck` to `xhEnvPollingConfig`, nest within authenticated /xh/environment return. Client reads and respects changes to config updates, with some sanity checks. + Restore /xh/version for backwards compat, return minimal environment summary.
# Conflicts: # CHANGELOG.md
# Conflicts: # admin/tabs/cluster/ClusterTabModel.ts
amcclain
approved these changes
Sep 3, 2024
| }, | ||
| { | ||
| track: () => XH.environmentService.serverInstance, | ||
| run: () => this.gridModel.agApi.refreshCells({columns: ['name'], force: true}) |
There was a problem hiding this comment.
Just refreshAsync()? Seems like a very good time to ensure your entire picture of what's in the cluster is up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.